search

ded / bonzo

library agnostic, extensible DOM utility
Other
1.32k stars 137 forks source link

Detach should use each(), not this.map() #80

Closed amccollum closed 12 years ago

amccollum commented 12 years ago

I don't see why detach shouldn't be using each. It's returning the same element set. Right now, code like the following will break:

$('div.some-div').detach().attr('some-attr')

Changing it to use each will fix this without needing to define a new method in the bridge.

ded commented 12 years ago

i see. makes sense