search

ded / domready

lets you know when the dom is ready
MIT License
874 stars 129 forks source link

Don't consider interactive mode as Dom loaded #31

Closed dcorb closed 10 years ago

dcorb commented 10 years ago

A month ago it was included this change, https://github.com/ded/domready/pull/26

where document.readystate "interactive" was considered equivalent as DOMContentLoaded.

That's not true in case of IE9 and IE10. They switch to 'interactive' state too early.

This is quite known bug in jQuery. Even it is documented in their code and bug reported. https://github.com/jquery/jquery/blob/2df1aad6a1c9376c2a477eba26ee992113ed1c23/src/core/ready.js#L76

I replicated the bug here : http://jsfiddle.net/corbacho/d9hLh/embedded/result/ Screenshot http://monosnap.com/image/VqBbDIZSMzLEnLgekxwngpkQ0yYSFw

theodoreb commented 10 years ago

Since we're using that in Drupal now is it possible to talk about formalizing the release process? That'd help us. Happy to take on the overhead if needed. Bug on drupal.org

ded commented 10 years ago

i see. i just removed < IE9 support, but tagged the last version. It might be a good idea to fork it from that point...

theodoreb commented 10 years ago

We don't want to fork if we can avoid it. Removing IE8 support wasn't an issue (new Drupal version won't support it). I saw it in the change logs and documented it.

The versioning wasn't clear, now there are version numbers and I'm assuming semver is used right?

To get back on the topic this problem was already raised and fixed in #17 (Issue was explicitly for IE9 and IE10) and was removed in e462a61ed080cd8f225c9513fa96266a6c51a227 a bit too delete happy I guess :D

jatinder85 commented 10 years ago

Is there a resolution on this issue? domready@1.0.5 is firing too soon in IE 9 and IE 10 for me.

dominykas commented 10 years ago

Readme says IE9+ is supported - can we please get this merged in?

theodoreb commented 10 years ago

Thanks!