search

ded / klass

a utility for creating expressive classes in JavaScript
751 stars 78 forks source link

`klass` 2.0 #6

Closed ghost closed 13 years ago

ghost commented 13 years ago

This is a massive rewrite of klass that normalizes support for the buggy for...in iteration algorithms in Internet Explorer and Safari, and removes function decompilation as discussed in issue #4. I've also updated the read me with several more examples. Cheers!

ded commented 13 years ago

Nice work — but this isn't really the same system anymore. You've nearly doubled the size and it's not backward compatible. I think you'd be better off releasing this as your own work and name it something else.

ghost commented 13 years ago

@ded No worries. I'll close issue #4, since this is the change that I suggested in it. Thanks for looking into this!

ded commented 13 years ago

don't get the wrong impression tho — i would really encourage you to release it as your own and totes m'gotes.

ghost commented 13 years ago

Sure, I completely understand! I had a feeling that this might have been too removed from your original intentions for klass, but I wanted to see what you thought first. Maybe I'll integrate my changes into Maddy, though...it already has a forEach method, and I always wondered why Underscore didn't include a class implementation by default.

matthew-dean commented 13 years ago

Hmm... will this solve my problem of Klass.js not evaluating at all? https://github.com/ded/klass/issues/8