dediagency / sylius-seo-plugin

Sylius SEO Plugin by Dedi.
26 stars 24 forks source link

phpstan error #42

Open t-n-y opened 2 years ago

t-n-y commented 2 years ago

Hi,

I installed the plugin and it works fine. But when i run phpstan, i got following errors :

Is it a way to fix that ? I saw that the getMainTaxon return a TaxonInterface but the getRichSnippetSubjectParent return RichSnippetSubjectInterface

Thank you for the help

costa-jeremy commented 1 year ago

Hello !

Up for this issue, i have the same problem.

Thanks :)

JulienLoison commented 1 year ago

Did you extend App\Entity\Product\ProductInterface with Dedi\SyliusSEOPlugin\Domain\SEO\Adapter\RichSnippetSubjectInterface ?

Last CI runs on #55 shows no issue

t-n-y commented 1 year ago

My product extends the Sylius\Component\Core\Model\Product which implements ReferenceableInterface and ReferenceableInterface, RichSnippetSubjectInterface

Like that : class Product extends BaseProduct implements ReferenceableInterface, RichSnippetSubjectInterface