Closed henrycg closed 12 years ago
Looks good, two minor gripes
Ok, I removed conf/web.
Pulled, could you disable the std out printed in the tests (about where the web server is). I'd eventually like to see a shutdown dissent webservice.
On 12/09/2011 07:51 PM, davidiw wrote:
Pulled, could you disable the std out printed in the tests (about where the web server is). I'd eventually like to see a shutdown dissent webservice.
Reply to this email directly or view it on GitHub: https://github.com/davidiw/Dissent/pull/4#issuecomment-3088291
I use the stdin/stdout stuff to communicate with the server because it makes easier to test a clean shutdown with valgrind (by sending "quit" on stdin). Catching ctrl-C with Qt is not portable and also requires a lot of signal handling code.
Hi David,
Do you want to take a look at this code and see what you think? I implemented the session hack for now and it seems to work just fine.
Henry