Time-invariant event log

pierluca commented 4 years ago

This pull requests deals with #2376 and adds a few documentation fixes. It makes the event log contract time-invariant by referring exclusively to the current block timestamp rather than time.Now()

I'm still looking into the unit-tests.

🙅‍ Friendly checklist:

[x] 0. Code comments are added (or updated) when/where needed and explain the WHY of the code.
[x] 1. Design choices, user documentation and any additional doc are added (or updated) in READMEs.
[ ] 2. Any new behaviour is tested and small units of code that can be are unit tested.
[ ] 3. Code comments are added on tests to explain what they do.
[ ] 4. Errors are systematically wrapped with a meaningful message using xerrors.Errorf and the %v verb.
[ ] 5. Hard limit of 80 chars is always respected.
[x] 6. Changes are backward compatible.
[x] 7. Indentation level does not exceed 5, although 4 is already suspicious.
[x] 8. Functions, files, and packages are kept to a manageable size and decomposed into smaller units if needed.
[x] 9. There are no magic values.

ineiti commented 4 years ago

Draft-comments: I started doing 2 separate PRs for separating:

comments changes that don't change the code
actual implementation of what I'm doing Of course I do this only once I'm done with the PR itself...

pierluca commented 4 years ago

I'm waiting for Travis to work, based on : https://github.com/dedis/cothority/pull/2383 and https://github.com/dedis/cothority/issues/2367

ineiti commented 4 years ago

You can rebase to master, the updates to the testing framework should make it work more reliable now. And if new tests fail, it'll be easier to make them pass...

ineiti commented 4 years ago

In fact the latest travis test failed because of an error in coveralls...

ineiti commented 4 years ago

@pierluca bumping this, as the byzcoin.BCTest is now in master and produces quite stable tests.

pierluca commented 4 years ago

Thanks for the information @ineiti. I'm committed to seeing this through, but it's not my # 1 priority right now. I'll come back to this as soon as I can find some spare time.

ineiti commented 3 years ago

Is this something you think working on, or should it be closed? You might want to delegate it ;)

pierluca commented 3 years ago

Considering Cothority is reaching C4DT support's end-of-life in April 2022 and that this feature is not currently used by any production system, I'm closing this PR. I'd be happy to pick it up again later should it become relevant / a priority.

dedis / cothority

Time-invariant event log #2382