search

dedis / cothority

Scalable collective authority
Other
426 stars 106 forks source link

Replacing travis with github actions #2410

Closed ineiti closed 3 years ago

ineiti commented 3 years ago

As Travis started to get slow, and as Jenkins is being eaten by the turkeys, this PR adds github actions to replace Travis.

Please have a look at the .github/workflows files and propose changes.

Closes #2395

ineiti commented 3 years ago

As far as I understand github/actions, the test.yaml is not run because the lint_build.yaml is not already in the workflow before the PR.

ineiti commented 3 years ago

push -f - yes, of course, I think I did one -f too many here. Usually I try to collect all changes to one commit between review rounds.

ineiti commented 3 years ago

Added a push: to the workflow, needs to be removed...

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gnarula commented 3 years ago

I'd like to suggest a release workflow as well. Something along the lines of https://github.com/gnarula/cothority/blob/master/.github/workflows/release.yaml that produces https://github.com/gnarula/cothority/releases/tag/v3.4.8 on pushing a tag.

I don't want to stall the merging of this PR so feel free to merge this if you'd like to discuss that in a separate PR or cherry-pick that change if you think it fits well

ineiti commented 3 years ago

I don't want to stall the merging of this PR so feel free to merge this if you'd like to discuss that in a separate PR or cherry-pick that change if you think it fits well

Just merged this PR. But please feel free to create a new PR for more functionality! We love it ;)