search

dedis / cothority

Scalable collective authority
Other
425 stars 106 forks source link

Move master branch to main branch #2452

Closed ineiti closed 3 years ago

ineiti commented 3 years ago

There are some Master references in the code, specifically in the evoting section, that I don't know if it's correct to replace them... @gnarula , any idea?

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

gnarula commented 3 years ago

I believe references to Master are for the skipchain that tracks all the other election skipchains. s/Master/Main and s/master/main shouldn't be okay. Is it fine if I add a commit to this branch?

ineiti commented 3 years ago

Is it fine if I add a commit to this branch?

Yes, of course. I was not sure whether I'd break anything, so I left it as-is. But if we're replacing the branch-name master, it makes also sense to replace the variable names called master...

gnarula commented 3 years ago

Digging into this, I see we'd require changes in dedis/epfl-evoting recreating the proto file in that repo.

I think we're too close to actual elections to be making changes and suggesting VPSI to use it for this cycle. Having said that I do have to make a release with #2451 though.

I don't want to block you on this PR so I'd suggest going ahead with the current changes. I can work on the evoting related changes in a separate PR in the next sprint (so sometime between the 10th-21st) if that's okay?

ineiti commented 3 years ago

I don't want to block you on this PR so I'd suggest going ahead with the current changes.

I thought of simply accepting that you still use Master for the evoting, but to move all the rest to main. Once you're ready to change the evoting code from master to main, this can be included later.

Added #2454

On an unrelated note: former master of India, prince Philipp, just died, might be a good occasion to move to main now ;)