dedis / cothority

Scalable collective authority
Other
425 stars 106 forks source link

Elections might not be finalizable #2511

Closed ineiti closed 1 year ago

ineiti commented 1 year ago

During the weekend I had the following thought: what if the condition you removed is about showing elections where the admin is not part of the election? Currently we always had test elections, where the admin was part, so it showed up twice. But what about an election where the admin is not part of the voters? Wouldn’t it be missing in the “Your elections”, and then it couldn’t be finalised? So perhaps the condition needs to be updated:

Can you check if I got that right? And if I did, can you please update the code accordingly?

PascalinDe commented 1 year ago

I'll go check

ineiti commented 1 year ago

It's not the candidates, but if you're part of the admins or voters.

PascalinDe commented 1 year ago

Yes, I re-read the comment, at least in the code there does not seem to be a filter on whether one is part of the voters.

In any case, it wouldn't make much sense if an admin couldn't see all elections. I'll test on an example to make sure.

PascalinDe commented 1 year ago

Screenshot 2023-07-03 at 09-02-59 evoting

only one voter (and one candidate! :rofl: ), and I'm not part of the voters

if we are looking for things to improve, I have access to the voting view, and can try to cast a ballot (which is rejected in the backend though)

ineiti commented 1 year ago

Great - thanks for checking that. So we're good. I wouldn't change too much at this stage. Let's wait what Pierluca says with regards to giving a hand on the D-voting project.