search

dedis / d-voting

📧 E-Voting platform based on the Dela blockchain
https://dedis.github.io/d-voting
BSD 3-Clause "New" or "Revised" License
18 stars 7 forks source link

Feat: adds voting permission #349

Closed lanterno closed 1 year ago

lanterno commented 1 year ago

This PR adds a new voting permission, and a CLI command that takes a list of voter IDs, and election ID to give those users voting permission over that election.

closes https://github.com/dedis/d-voting/issues/305

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6255908120

Totals Coverage Status
Change from base Build 6250984089: 0.0%
Covered Lines: 3269
Relevant Lines: 5696
💛 - Coveralls
lanterno commented 1 year ago

I will fix the linting, and rebase over main @ineiti @pierluca

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

lanterno commented 1 year ago

@ineiti All tests are good now.

I also looked at the go integration tests which fail mostly on the CI, and they don't depend on the Typescript code, so it's safe to ignore the failures in the future if there's no GoLang code changed.

ineiti commented 1 year ago

@ineiti All tests are good now.

Great - for the other reviews of this PR I clicked myself on the "re-run tests" :)