search

dedis / d-voting

📧 E-Voting platform based on the Dela blockchain
https://dedis.github.io/d-voting
BSD 3-Clause "New" or "Revised" License
18 stars 7 forks source link

Cleanup debugging #365

Closed ineiti closed 1 year ago

ineiti commented 1 year ago

Cleans up some of the now unused debugging things and 'dev' Dockerfiles.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6322897853

Totals Coverage Status
Change from base Build 6300308902: 0.0%
Covered Lines: 3269
Relevant Lines: 5696
💛 - Coveralls
sonarcloud[bot] commented 1 year ago

Please retry analysis of this Pull-Request directly on SonarCloud.

lanterno commented 1 year ago

@ineiti You need to rebase/merge

ineiti commented 1 year ago

@lanterno done.

ineiti commented 1 year ago

Why remove the debug dockerfiles ? It was super painful to get it just right 😅

We never actually used them, and I'm preparing #366 which allows running a whole system locally w/o docker, similar to runSystems.sh, but ready for voting. So you can also directly run a node with Goland without having to go through docker.

But if you promise you'll use it, I'll put it back in.

pierluca commented 1 year ago

Err, I did actually use it with @PascalinDe . I think it doesn't hurt to keep it around. I appreciate the #366 initiative (very much so, it looks very neat!), but I'm a little confused - I was under the impression that @PascalinDe 's effort to containerize the environment was that we could (eventually) get rid of those scripts and develop with the convenience of a pre-production environment ?

ineiti commented 1 year ago

Different environments are needed for different types of development. @PascalinDe 's efforts to containerize the environment supposed we only need to do small debugging and adjustments. As it turned out, there were a lot of things to fix and change, and for faster debugging cycles I prefer having everything in the shell w/o docker.

Once it works locally, it's nice to have a docker environment to test it on other machines, too, without them having to install all the development environment.

So it's two approaches for two different development use-cases.

Adding the debug Dockerfile in again.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

PascalinDe commented 1 year ago

@pierluca we are currently working on a Dockerfile that includes the debug environment: https://github.com/dedis/d-voting/pull/364/files

the idea is mainly to reduce the number of docker compose/Dockerfiles because it's become pretty confusing keeping them all up to date

ineiti commented 1 year ago

Closing in favour of c4dt/d-voting#3