Closed pierluca closed 1 year ago
Observation: The fake store implementation didn't respect the API's intentions. It's unclear if this is the cause of the bug we observe.
Observation: fixing the fake store prevents the panic.
However, the test still fails and it appears the panic was caused by the test going "too far" before failing.
I'm now testing the hypothesis that the failure is due to a file existing (unexpectedly) in the filesystem.
Conclusion: the test failure was due to changes in the Golang crypto library.
The elliptic curve we assumed would be unsupported is now fully supported.
As such, I've modified the badCurve
implementation to be a genuinely broken, unsupported implementation.
@jbsv if the new panic message works for you, I'll let you merge :)
Kudos, SonarCloud Quality Gate passed!
This is a candidate fix as it's hard to reproduce locally on my Mac, I'll be using the CI to verify.
Fixes #249