dedis / dela

DEDIS Ledger Architecture
https://dedis.github.io/dela
BSD 3-Clause "New" or "Revised" License
17 stars 14 forks source link

Fix panic in TestMiniController_FailMarshalKey_OnStart #252

Closed pierluca closed 1 year ago

pierluca commented 1 year ago

This is a candidate fix as it's hard to reproduce locally on my Mac, I'll be using the CI to verify.

Fixes #249

pierluca commented 1 year ago

Observation: The fake store implementation didn't respect the API's intentions. It's unclear if this is the cause of the bug we observe.

pierluca commented 1 year ago

Observation: fixing the fake store prevents the panic.

However, the test still fails and it appears the panic was caused by the test going "too far" before failing.

I'm now testing the hypothesis that the failure is due to a file existing (unexpectedly) in the filesystem.

pierluca commented 1 year ago

Conclusion: the test failure was due to changes in the Golang crypto library.

The elliptic curve we assumed would be unsupported is now fully supported.

As such, I've modified the badCurve implementation to be a genuinely broken, unsupported implementation.

pierluca commented 1 year ago

@jbsv if the new panic message works for you, I'll let you merge :)

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication