Implementation of the cipher suite registry

dedis / onet

Overlay Network for distributed protocols

GNU Lesser General Public License v3.0

51 stars 29 forks source link

Closed Gilthoniel closed 4 years ago

Gilthoniel commented 5 years ago

Add a ciphersuite package that contains the abstraction of the cryptographic primitives.
Add a builder.go file that contains the implementation of a server builder.
Remove the public API to create a server.
Remove the service factory to have a non-static service registration through the builder.

Closes #579

ineiti commented 5 years ago

Is there a document describing what you're doing here?

Gilthoniel commented 5 years ago

Question:

Gilthoniel commented 5 years ago

Follow-ups (marked as TODO in the code):

server.go : it's using an online service to verify the connection or find the host
builder.go : better check of the parameters
service.go : database name mixed between the builder and old logic
simulation.go : better use of the builder if possible

Gilthoniel commented 5 years ago

I heard your thoughts! Thanks, I'm going to create multiple small PRs with independent modules and a last one to make them work together.