search

dedis / onet

Overlay Network for distributed protocols
GNU Lesser General Public License v3.0
51 stars 29 forks source link

Got it to failing, but... #656

Closed ineiti closed 4 years ago

ineiti commented 4 years ago

The update to the new TLS handshake is faulty. The test in #655 only tests old->old and new->new, but not new->old and old->new (which fails).

This PR tests all combinations, but fails. Currently I don't know why :(

The relevant test is here: https://github.com/dedis/onet/pull/656/files#diff-f183c5e9370db10aaa3413143732a5abR46

jeffallen commented 4 years ago

So I'm a little unclear on where the changes to the error logging came from, don't know if they need to be there, in which case we need to fix the tests.

Also, not clear on what this tells us: it seems like this proves that this change is backwards compatible, but clearly the experience with the production network says it was not.

ineiti commented 4 years ago

Also, not clear on what this tells us: it seems like this proves that this change is backwards compatible, but clearly the experience with the production network says it was not.

What has been 'tested in prod' and failed is the following: old (1.14) -> new (1.15) And this is very hard to test - should be more of an integration test with a test.sh that takes old code and compiles it with 1.14 and tries to connect to new code compiled with 1.15...

Closing in favour of #657