search

dedis / onet

Overlay Network for distributed protocols
GNU Lesser General Public License v3.0
50 stars 29 forks source link

Replace satori/go.uuid with google/uuid #661

Closed gnarula closed 4 years ago

gnarula commented 4 years ago

Replaces the uuid dependency to google/uuid which is actively maintained and uses go.mod

Closes #660

gnarula commented 4 years ago

I don't think uuid.UUID is exposed directly to the users - the end users would always deal with types like ServerIdentityID and the methods defined on it.

Under the hood, both dependencies share the same representation and conform to the same spec: https://github.com/satori/go.uuid/blob/b2ce2384e17bbe0c6d34077efa39dbab3e09123b/uuid.go#L37 and https://github.com/google/uuid/blob/0e4e31197428a347842d152773b4cace4645ca25/uuid.go#L19

ineiti commented 4 years ago

Did you try to compile dedis/cothority using these changes?

ineiti commented 4 years ago

So I can compile dedis/cothority with these changes - so it should be OK...

gnarula commented 4 years ago

@ineiti it builds fine but I'm getting some test failures on dedis/cothority which I'm looking into

router.go:215 (network.(*Router).Start.func1) - receiving server identity from "" failed: Error while receiving ServerIdentity during negotiation receiving: [::1]:64212 sends too big packet: 1195725856>10485760

Edit: Nvm, getting it irrespective of this change :/

ineiti commented 4 years ago

Edit: Nvm, getting it irrespective of this change :/

Which test is that?

gnarula commented 4 years ago

Edit: Nvm, getting it irrespective of this change :/

Which test is that?

blscosi.TestClient_SignatureRequest, blscosi.TestService_SignatureRequest byzcoin.TestClient_NoPhantomSkipchain,contracts.TestDeferred_ExpireBlockIndex, calypso.TestClient_Authorize

ineiti commented 4 years ago

blscosi.TestClient_SignatureRequest, blscosi.TestService_SignatureRequest byzcoin.TestClient_NoPhantomSkipchain,contracts.TestDeferred_ExpireBlockIndex, calypso.TestClient_Authorize

Here the error disappears if I run them individually - can you confirm that? Else we'll need to open an issue for this...

gnarula commented 4 years ago

blscosi.TestClient_SignatureRequest, blscosi.TestService_SignatureRequest byzcoin.TestClient_NoPhantomSkipchain,contracts.TestDeferred_ExpireBlockIndex, calypso.TestClient_Authorize

Here the error disappears if I run them individually - can you confirm that? Else we'll need to open an issue for this...

Same here, errors disappear if I run the tests individually

ineiti commented 4 years ago

So I think this should go in.