search

dedis / onet

Overlay Network for distributed protocols
GNU Lesser General Public License v3.0
51 stars 29 forks source link

websocket: do not error on service's close #672

Closed tharvik closed 3 years ago

tharvik commented 3 years ago

When a stream is closed by the service itself (such as when the service was streaming progress and finished with a result), it actually errors with "unexpected error: service finished streaming". As it is quite an expected behavior, I'm removing this error and closing the websocket.

It clashes with #670, as we might want to keep the channel opened, anyway, it doesn't change the current behavior of closing the channel when service finishes, just avoid the error.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

ineiti commented 3 years ago

@nkcr can you please merge the PR? I think because it comes from the c4dt repo, it cannot run the travis CI - Branch test, so I cannot merge...