dedis / popstellar

Proof-of-personhood System
GNU Affero General Public License v3.0
35 stars 8 forks source link

Valid Pop token format #1664

Open K1li4nL opened 1 year ago

K1li4nL commented 1 year ago

For now the form a valid PoP token must have is undefined. For example, the scala backend will consider any base64 strings to be acceptable pop tokens, including empty ones, leading to issues when creating channels for rollcall participants... Another example is Fe1 that doesn't even have the requirement of them being base64 when scanning tokens during rollcall. There is a need to agree on the format (i.e: regex) valid pop token should have so as to avoid as much as possible undefined behaviours among subsystems.

Subsystems concerned:

Front-ends:
Back-ends:
Tyratox commented 7 months ago

See https://github.com/dedis/popstellar/blob/master/protocol/qrcode/pop_token.json

osm-alt commented 6 months ago

I see that all tasks have been marked as done. Should this issue be closed?

K1li4nL commented 6 months ago

My bad, the way I put it is confusing (I initially selected all the systems as a way to show they were all concerned, edited now). Given that the pop token is still defined as a format-less string I wouldn't say this issues is solved (unless it is decided things are good enough this way)