github-actions[bot]
commented
3 months ago Pull reviewers stats
| Stats of the last 30 days for popstellar: | User | Total reviews | Time to review | Total comments | |
|---|---|---|---|---|---|
 |
K1li4nL 🥇 |
8 ▀▀ |
4d 21h 51m)) ▀ |
23 ▀ |
|
 |
pierluca 🥈 |
5 ▀ |
6d 22h 1m)) ▀ |
8 ▀ |
|
 |
onsriahi14 🥉 |
5 ▀ |
3d 1h 48m)) |
10 ▀ |
|
 |
matteosz |
5 ▀ |
4d 40m)) |
20 ▀ |
|
 |
arnauds5 |
4 ▀ |
7d 5h 54m)) ▀ |
12 ▀ |
|
 |
simone-kalbermatter |
4 ▀ |
1d 14h 46m)) |
0 |
|
 |
quadcopterman |
4 ▀ |
5d 19h 9m)) ▀ |
1 |
|
 |
Tyratox |
2 |
14d 6h 12m)) ▀▀ |
45 ▀▀▀ |
|
 |
1florentin |
2 |
8d 13h 48m)) ▀ |
6 |
|
 |
t1b00 |
2 |
6d 6h 52m)) ▀ |
4 |
|
 |
osm-alt |
2 |
6d 22h 53m)) ▀ |
12 ▀ |
|
 |
ljankoschek |
2 |
18m)) |
0 |
|
 |
DanielTavaresA |
2 |
2d 10h 22m)) |
8 ▀ |
|
 |
Kaz-ookid |
2 |
7d 15h 16m)) ▀ |
7 |
|
 |
sgueissa |
1 |
2d 23h 56m)) |
1 |
|
 |
MariemBaccari |
1 |
1d 16h 52m)) |
0 |
|
 |
emonnin-epfl |
1 |
51m)) |
1 |
sonarcloud[bot]
No data about Coverage
Pending on #1877
Added the possibility to have a list of rumors in the response. Some refactoring was needed because Scala do not see two List[A] and List[B] as different types. For that I added a new sealed trait ResultTypes that represents all possible ResultTypes. With this structure it is more manageable for future additions is more intuitive with a ResultObject having only one result and not one result for each possible type. ResultEmptyList is a "dirtyfix". It is necessary because for jsonRPC coming in, if list is empty it is impossible to differentiate a List[Rumor] or List[Message]. ResultEmptyList is a handled in a way that it returns a emptyList for both List[Rumor] and List[Message]. Such behaviour si not a real problem because there using jsonRPC id should avoid any conflict.