Closed DanielTavaresA closed 3 months ago
Stats of the last 30 days for popstellar: | User | Total reviews | Time to review | Total comments | |
---|---|---|---|---|---|
K1li4nL 🥇 |
10 ▀▀ |
4d 21h 51m)) |
23 ▀ |
||
pierluca 🥈 |
5 ▀ |
6d 22h 1m)) ▀ |
8 ▀ |
||
onsriahi14 🥉 |
5 ▀ |
3d 1h 48m)) |
10 ▀ |
||
matteosz |
5 ▀ |
4d 1h 36m)) |
22 ▀ |
||
simone-kalbermatter |
4 ▀ |
1d 14h 46m)) |
0 |
||
quadcopterman |
4 ▀ |
5d 19h 9m)) ▀ |
1 |
||
arnauds5 |
3 ▀ |
8d 13h 44m)) ▀ |
8 ▀ |
||
Tyratox |
2 |
27d 19h 54m)) ▀▀▀ |
48 ▀▀▀ |
||
t1b00 |
2 |
6d 6h 52m)) ▀ |
4 |
||
osm-alt |
2 |
6d 22h 53m)) ▀ |
12 ▀ |
||
ljankoschek |
2 |
18m)) |
0 |
||
DanielTavaresA |
2 |
2d 10h 22m)) |
8 ▀ |
||
Kaz-ookid |
2 |
7d 15h 16m)) ▀ |
7 |
||
1florentin |
1 |
8d 13h 49m)) ▀ |
6 |
||
sgueissa |
1 |
6d 11h 44m)) ▀ |
1 |
||
emonnin-epfl |
1 |
51m)) |
1 |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
I am not entirely sure what these changes means for the overall design, it reduces a level of indirection in the handlers which is nice but means PublishSubscribe is a hard dependency for the entire system. I don't see any other way to fix the problem you are trying to fix without a larger changes right now so we might as well go that way.
Agree, buildGraph is tight to adding references to the system, which doesn't seem a natural behaviour. Overall, a lot of references are passed around, eventhought they are unique in the system. We could try to centralize those references using maybe https://doc.akka.io/docs/akka/current/typed/actor-discovery.html as you recommended.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
fixes the issue of using the wrong refs for the database.
Now all refs from code come from the PublishSubscribe graph, and if something should be injected, it is being done through PublishSubscribe.buildgraph(...)