dedis / popstellar

Proof-of-personhood System
GNU Affero General Public License v3.0
35 stars 8 forks source link

[BE1] Top-Down Backend #1911

Closed sgueissa closed 3 months ago

sgueissa commented 3 months ago

In this PR, we removed the singletons that were really annoying for testing and replace them with a top-down dependencies injection architecture.

All the differents handlers can be find inside the directory Handler and the building of the architecture inside the package Hub.

In this PR the following are still missing but will be done in the next PRs:

  1. Fix the coverage of sonar
  2. Fix the comments from https://github.com/dedis/popstellar/pull/1815
  3. Add documentation
  4. Add a better logging system
  5. Finish the cleaning and organization of the files
  6. Add some integration tests
  7. Add karate tests
github-actions[bot] commented 3 months ago

Pull reviewers stats

Stats of the last 30 days for popstellar: User Total reviews Time to review Total comments
K1li4nL
🥇
17
▀▀▀▀
3d 23h 9m))
20
▀▀▀▀
simone-kalbermatter
🥈
4
8h 40m))
0
onsriahi14
🥉
4
1d 10h 51m))
5
matteosz
4
1d 7h 45m))
4
DanielTavaresA
3
2d 19h 23m))
10
▀▀
pierluca
2
3d 11h 3m))
1
emonnin-epfl
2
3h 14m))
2
Tyratox
1
44m))
0
arnauds5
1
10d 19h 13m))
▀▀▀
0
sgueissa
1
6d 11h 44m))
▀▀
1
osm-alt
1
25m))
0
quadcopterman
1
4d 2h 40m))
0
Kaz-ookid
1
1d 2h 1m))
5

⚡️ Pull request stats

sonarcloud[bot] commented 3 months ago

Please retry analysis of this Pull-Request directly on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud