When sending coins to another user, and opening the Transaction History (top right corner), we can see the recent send. It displays : To: {$receiver_token_hash}. But this token hash is clearly not the one we sent coins to, and is not even 32 bytes (a PoP Token/Public Key length). This feels wrong and should be investigated.
This only happens for transactions for which we are the sender.
Expected behavior
Display the token of the receiver of the transaction.
How to reproduce
Create a LAO, Join it with another device, create a RollCall, Scan your second device and close the RollCall
Go to Digital Cash
Click on Send and remember the user token
Enter a non-null amount and click on Send
See the Receipt view
Click in the top right corner on the Transaction History icon
See the Transaction History
Click on the recent transaction to deploy the details
See the error (wrong hash of the receiver token)
Version & Environment
This bug was reproduced on:
Commit: ...hash... (make sure your working tree is clean and your commit is pushed to the repo)
Front-ends:
[ ] Fe1-Web (please include browser's names & version)
[x] Fe2-Android (please specify if phone or emulation, and Android version)
[ ] Not applicable
Back-ends:
[ ] Be1-Go
[ ] Be2-Scala
[ ] Not applicable
Impact
Low user experience impact, as it is not a much used feature for now. However, it will be a lot more confusing once we get the username display from #1915.
Description
When sending coins to another user, and opening the Transaction History (top right corner), we can see the recent send. It displays :
To: {$receiver_token_hash}. But this token hash is clearly not the one we sent coins to, and is not even 32 bytes (a PoP Token/Public Key length). This feels wrong and should be investigated.This only happens for transactions for which we are the sender.
Expected behavior
Display the token of the receiver of the transaction.
How to reproduce
Digital CashSendand remember the user tokenSendReceiptviewTransaction History iconTransaction HistoryVersion & Environment
This bug was reproduced on:
Front-ends:
Back-ends:
Impact
Low user experience impact, as it is not a much used feature for now. However, it will be a lot more confusing once we get the username display from #1915.
Possible root cause
https://github.com/dedis/popstellar/blob/e47fa9acd0045b71e4db8057dbaee4aac6025011/fe2-android/app/src/main/java/com/github/dedis/popstellar/ui/lao/digitalcash/HistoryListAdapter.kt#L111 This line is responsible of what to display after the
To:. Need to understand where those hashes come from and what they represent, as they can't possibly represent users tokens (less than 32 bytes long)Screenshots
This is not the token I sent coins to. (the visual bug has been fixed in #1921