dedis / popstellar

Proof-of-personhood System
GNU Affero General Public License v3.0
35 stars 8 forks source link

Message validation for the rest of Federation messages #1959

Closed quadcopterman closed 1 month ago

quadcopterman commented 1 month ago

Added message validation on all federation messages that hadn't validation before

github-actions[bot] commented 1 month ago

Pull reviewers stats

Stats of the last 30 days for popstellar: User Total reviews Time to review Total comments
K1li4nL
🥇
24
▀▀▀▀
1d 19h 44m))
12
▀▀
arnauds5
🥈
7
4h 29m))
4
matteosz
🥉
7
3d 16h 27m))
21
▀▀▀
emonnin-epfl
6
8h 20m))
8
sgueissa
3
7h 59m))
5
quadcopterman
3
10d 7h 3m))
▀▀▀
1
1florentin
2
10d 5h 50m))
▀▀▀
0
MariemBaccari
2
22h 39m))
6
simone-kalbermatter
2
5h 32m))
0
onsriahi14
2
6d 4h 27m))
▀▀
4
Kaz-ookid
1
3d 19h 13m))
5

⚡️ Pull request stats

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
16.0% Duplication on New Code

See analysis details on SonarCloud

quadcopterman commented 1 month ago

Yes it's a good idea to write that somewhere. However we might forget a TODO in the code (nobody will see it unless working on these specific lines of the project), so I think it's better if I mention that in issue #1751 so we can see what still needs validation more globally :)