dedis / prifi

PriFi, a low-latency, local-area anonymous communication network.
https://prifi.net
GNU Affero General Public License v3.0
48 stars 11 forks source link

Commit id check #149

Closed PierreSL closed 7 years ago

PierreSL commented 7 years ago

Solves #124

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 89.869% when pulling 6725b8006a213d055ca689695b6eb81283e2677e on commitID-check into be5d245e702d032e2b22db51c43694eba9018160 on master.

lbarman commented 7 years ago

Thanks for the great work. Is there any possibility to put the variable commitID in one of the config data structure, instead of passing it as an argument to StartTrustee() (so we keep the parameters grouped ?)

E.g., in prifiTomlConfig; the field would remain blank when parsing the Toml, but you would fill it as you do it now. Then every layer of PriFi has access to this variable without passing it.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 89.869% when pulling 031a3ac9ed0ed0c74c413d441c9c7a002b6508b3 on commitID-check into be5d245e702d032e2b22db51c43694eba9018160 on master.

lbarman commented 7 years ago

I renamed the fields "CommitID" to "ProtocolVersion" for clarity. What do you think ?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 89.869% when pulling 038d70432430dc5c4d0448171cc41a8f10359baf on commitID-check into be5d245e702d032e2b22db51c43694eba9018160 on master.