search

dedis / prifi

PriFi, a low-latency, local-area anonymous communication network.
https://prifi.net
GNU Affero General Public License v3.0
48 stars 11 forks source link

Fix memory leak: clean history when round is done #222

Closed cmalchik closed 3 years ago

cmalchik commented 3 years ago

The relay's memory usage increases by a few hundred MB per minute due to messages kept after they are no longer needed. This change deletes the unneeded data at the end of each round.

ineiti commented 3 years ago

I don't know the state of tests in prifi - but would it be possible to create a test to make sure this works as required?

cmalchik commented 3 years ago

There are some integration tests which check that the protocol runs, suggesting that we are not deleting too much. Beyond that, automated testing for memory leaks seems difficult because memory usage may increase for good reason.

I'll merge this in a few days if you don't object.

ineiti commented 3 years ago

I think @lbarman should approve - can you put him in the reviewers?

cmalchik commented 3 years ago

Ludovic is no longer working on PriFi officially, though he voiced approval for the patch over email. It looks like there are some broken tests that are blocking merging (not sure if I can bypass them). I don't have the permissions to access the repo's test settings, but the problems might be related to these issues:

https://github.com/travis-ci/travis-ci/issues/10204 https://github.com/lemurheavy/coveralls-public/issues/905

Could you possibly look into this?

ineiti commented 3 years ago

I discussed yesterday with Ludovic and he explained me the situation. I think the best is to add you to dedis/prifi with write access, so that you can correctly launch the tests. Then you'll have to re-create the branch in the dedis/prifi repo, and it should be OK.

@jeffallen @pierluca - can you add @cmalchik with write permission to dedis/prifi? He's the new supporter of it...