search

dedis / protobuf

Reflection-based Protocol Buffers for Go
GNU General Public License v2.0
76 stars 15 forks source link

failing test with []int #14

Closed ineiti closed 6 years ago

ineiti commented 8 years ago

Adds two tests with regard to ints:

ineiti commented 8 years ago

Should be tested against latest protobuf as Ismail worked on the en/decoding of slices.

liamsi commented 8 years ago

Should be tested against latest protobuf as Ismail worked on the en/decoding of slices.

I don't think my changes would resolve this issue. They were only related to map (or maps with arrays as values).

ineiti commented 8 years ago

And here we have the problem of what to do with int - should it be encoded as 32 or 64-bit value? What if size(int) is different on the sender or the receiver?

marco709394 commented 8 years ago

Just curious, why not just treat int slice as int64 like you do the case of int32 ? Please ignore me if it is no longer an issue or you have other consideration :)

liamsi commented 8 years ago

Just curious, why not just treat int slice as int64 like you do the case of int32 ? Please ignore me if it is no longer an issue or you have other consideration :)

It's still an issue. If you have time we are happy about a PR :-) If not, we will take care of that issue soon, anyways.

liamsi commented 8 years ago

@marco709394 added a PR realted to this issue: #28

ineiti commented 6 years ago

Look at the PR from @Liamsi and see if we can include it.

ineiti commented 6 years ago

Superseded by #42