search

dedis / protobuf

Reflection-based Protocol Buffers for Go
GNU General Public License v2.0
76 stars 15 forks source link

fix interface type decoded as empty value by recursive approach #26

Closed marco709394 closed 8 years ago

marco709394 commented 8 years ago

Found that field with interface type is decoded without value if it does not support "UnmarshalBinary". I am not very sure about how "putvalue" works but recursively calling "Decode" solved the problem

ineiti commented 8 years ago

Thanks for the bug-report - do you have a test-case we could add to better understand what's going on?

ineiti commented 8 years ago

Looks fine to me - I don't know whether that makes our protobuf even more incompatible with the standard or not.

liamsi commented 8 years ago

Looks fine to me - I don't know whether that makes our protobuf even more incompatible with the standard or not.

Looks fine to me, too. Thanks a lot for your effort @marco709394! I'll test if this has any side-effect or introduces any incompatibility.

nikkolasg commented 8 years ago

+1

ineiti commented 8 years ago

Tested with cothority - it works.