dedis / protobuf

Reflection-based Protocol Buffers for Go
GNU General Public License v2.0
76 stars 15 forks source link

fix bugs when decode struct that has unsorted fields #53

Closed let-s-go closed 5 years ago

jeffallen commented 5 years ago

Hello. Couple questions... who are you? What are you trying to do that is not working?

This PR won't be ready to merge until it has a test which shows the problem that it is trying to fix, thanks.

ineiti commented 5 years ago

I think it might have to do with trying to do protobuf.Decode on protobuf-data where the field-order is not correct. But a test for that would be very welcome. And removing the debug-lines.

jeffallen commented 5 years ago

No test, no fix. Closing this until @let-s-go can explain what the problem is he/she is trying to fix.