(Un)Marshaling structs with internal Binary(Un)Marshaler support

dedis / protobuf

Reflection-based Protocol Buffers for Go

GNU General Public License v2.0

76 stars 15 forks source link

(Un)Marshaling structs with internal Binary(Un)Marshaler support #64

Closed b00f closed 5 years ago

b00f commented 5 years ago

In this patch structs that implemented Marshal/UnmarshalBinray Methods can be encoded/decoded correctly even it's added as a filed. A good example is using cid for referring a doc inside a block.

jeffallen commented 5 years ago

This is excellent, thanks. Please print and sign a CLAI (or CLAC, if this work is for your employer). You can find an explanation/instructions here: https://github.com/dedis/cothority/blob/master/CONTRIBUTION

jeffallen commented 5 years ago

The author has contacted me privately and declined to sign the CLAC. I'm closing this PR, but we may implement this ourselves.