search

dedoc / scramble

Modern Laravel OpenAPI (Swagger) documentation generator. No PHPDoc annotations required.
https://scramble.dedoc.co/
MIT License
1.13k stars 106 forks source link

No hints are displayed when merging requests #468

Open DarKsandr opened 1 month ago

DarKsandr commented 1 month ago

I have two requests that I merged into one. When applying the received request, there are no hints. Снимок экрана от 2024-07-26 11-33-47 Снимок экрана от 2024-07-26 11-34-42 Снимок экрана от 2024-07-26 11-39-15 Снимок экрана от 2024-07-26 11-39-49 Снимок экрана от 2024-07-26 11-40-05

DarKsandr commented 1 month ago

I thought that double-specifying the request would work, but only the first one that exists is displayed. Снимок экрана от 2024-07-26 21-03-11 Снимок экрана от 2024-07-26 21-04-33

DarKsandr commented 1 month ago

@romalytvynenko is there a solution to the problem?

romalytvynenko commented 1 month ago

@DarKsandr it should be fixed with https://github.com/dedoc/scramble/pull/237 , but this is not that fast.

DarKsandr commented 1 month ago

@romalytvynenko got it, thanks. but isn't the second example a bug? shouldn't it combine several requests? i thought it would work the same way as in this example: Снимок экрана от 2024-07-31 15-51-08 Снимок экрана от 2024-07-31 15-49-25

romalytvynenko commented 1 month ago

Personally to me this is hard to consider it as a bug, as I never saw such usage of requests. I agree this may be improved, but rather than an improvement, not a bug, IMO

DarKsandr commented 1 month ago

@romalytvynenko If such an improvement were to appear, I would be glad. But IMHO it is still a bug, because the parser does not take into account all method requests, but only the first one.

romalytvynenko commented 1 month ago

@DarKsandr feel free to open a PR :-)