search

dedoussis / icloud-hide-my-email-browser-extension

Enjoy iCloud's Hide My Email service in your favourite browser
https://chrome.google.com/webstore/detail/icloud-hide-my-email/omiaekblhgfopjkjnenhahfgcgnbohlk
MIT License
319 stars 15 forks source link

Orion Browser and Authenticating #45

Open kormose opened 10 months ago

kormose commented 10 months ago

Hi, so I am giving Orion a go at the moment, which promises Firefox / Chrome plugin compatibility. I am using a few extensions from Firefox and Chrome store, and Hide My Email installs correctly as well, from both extension stores.

However I am running into issues with signing in to iCloud using Hide My Email. I complete the login process on iCloud.com and can access my account, but the login never affects Hide My Email. It remains signed out. I don't get the 2FA prompt either. Any ideas on what I could try?

dedoussis commented 9 months ago

Hi @kormose! I dogfooded the extension in Orion and encountered the same issue. After some debugging I figured out that Orion does not fully implement the extension API. The Chrome version of the extension (MV3) relies on declarativeNetRequests, whereas the Firefox one (MV2) relies on blocking webrequests. As far as I understand, Orion does not support any of those (possibly by design).

Edit: Came across this extension API support matrix of Orion. It seems that declarativeNetRequests is indeed not supported, but they suggest that webrequests.onBeforeSendHeaders is. Based on that, the Firefox port of the extension should have been working on Orion. When debugging, I confirmed that Orion invokes the onBeforeSendHeaders listeners of the extension but for some reason it did not actually apply the header modifications. Probably worth flagging this with the folks at Orion.

kormose commented 9 months ago

Thank you so much for investigating! I will flag this up with them.

relink2013 commented 3 months ago

I came here to ask this exact question. I was really excited to see this extension but sadly im having the same issues. Except I seem to be having an extra cosmetic issue too, see the image below.

Even if it's hacky for now, has anyone managed to get the extension working?

The cosmetic issue happens with both the Chrome and Firefox versions. Though based one the conversation above I currently have the Firefox version installed.

Even though this is technically a different issue, I put it here with the other Orion topic since it's more relevant to this specific browser than it is the extension itself.

Screenshot 2024-08-02 at 10 03 07 AM

dedoussis commented 2 weeks ago

@relink2013 thanks for reporting this. I'd suggest flagging this with the Orion folks as it could be a wider issue on how Orion renders extension popups.