dedsecrattle / pe

0 stars 0 forks source link

Invalid Prefixes not detected #8

Open dedsecrattle opened 2 months ago

dedsecrattle commented 2 months ago

image.png

provided with an invalid prefix i.e. test/lol , the Application shows an error regarding the email format , however an expected message would be Invalid Command Format for the user to identify the mistake

Command Executed - add stu /n John Doe /i A0123456Z /p 98765432 /e johnd@example.com test/lol

nus-pe-script commented 2 months ago

Team's Response

Based on our UG, our product's valid prefix starts with '/', so the tester's input of 'test/' is not a prefix conforming to our set format.

Furthermore, even if the tester tests with a conforming prefix like '/test', our app will still perceive the whole chunk of "johnd@example.com test/lol" as an input to the email field, in which the input email format is wrong. Therefore, the error message of wrong email input is the correct expected behaviour.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Apologies for the wrong image attachment in the exam rush condition ,

image.png

Consider this scenario when use unfortunately enters a invalid prefix d instead of n (which is a valid prefix for the application) and enters , Since the Application says email is not valid , this error message displayed is not correct and inconsistent with the exact problem or error since we can clearly see this is a case of invalid prefix which should be reflected to the user as a Invalid Command format so instead of invalid email , this can cause confusion and inconvenience for the user to actually understand the problem.

the argument was still about invalid prefixes and wrong feedback to the user