search

deedey / moodle-block_annulab_lrs

This block for Moodle gives access to a user’s own historical data sent by the moodle's logstore_xapi and tincanlaunch plugins to the LRS of Annulab in a graphical format and data table. It requires a free subscription at https://lrsdata.com. The LRS enables anyone who is connected to import his/her own data in a JSON format file archived into a ZIP file.
1 stars 0 forks source link

pluginname incorrect #8

Closed danmarsden closed 6 years ago

danmarsden commented 6 years ago

https://github.com/deedey/moodle_block_annulab_lrs/blob/master/lang/en/block_annulab_lrs.php

the "pluginname" should really be something like "Annulab LRS Block"

also make sure you remove the php close tag from that file and add the gpl boilerplate to the top.

deedey commented 6 years ago

Thank you this comment Dan I've changed the "pluginname" to "Annulab LRS Block" and I've removed End Tag

danmarsden commented 6 years ago

doesn't look like you have pushed the commit for that change? https://github.com/deedey/moodle-block_annulab_lrs/blob/master/lang/en/block_annulab_lrs.php

I still see "My own data" instead of "Annulab LRS" - now that I am thinking clearly - it probably doesn't need to contain the word "Block" like I mentioned - typically users will see it in a list of blocks so "Annulab LRS" is probably sufficient :-)

deedey commented 6 years ago

As you suggest it, I've changed in all script lang "My own data" to "Annulab LRS"