deefactorial / openmoney-network

Openmoney Client for the Openmoney API
3 stars 2 forks source link

No account validation on transfer #2

Open edwardont opened 4 years ago

edwardont commented 4 years ago

When attempting to process a payment to an account that is not "visible", there is inconsistent and confusing checking to verify the receiving account/namespace exists.

A debit is shown on the account overall balance and also the ledger shows the transaction but the recipient doesn't exist in this namespace It means the amount transfered is "lost".

The error seems to occur when there is a matching account name and currency on the openmoney.network website in the cc namespaces//accounts add; A few weeks ago a fresh instance allowed sending to a namespace with no account defined.

Creating the recipient account after the fact in the cc namespace is not allowed because; "There is another account with that name"

We tried to recreate this issue in a new namespace (testlaughtest.cc cc) and the output was; "Their account does not exist in this currency" as expected

This was tested on the openmoney.network site and replicated on the site

This appears to be caused by issue #3

edwardont commented 4 years ago

Background; I am looking at the interface with an end user perspective The first thing I tried was to send currency to another account in another circle/namespace, without saving or adding any accounts or namepaces so it defaulted to the cc namespace This was very confusing as a noob.