search

deegree / deegree3

Official deegree repository providing geospatial core libraries, data access and advanced OGC web service implementations
https://www.deegree.org
GNU Lesser General Public License v2.1
146 stars 100 forks source link

[v.3.4-pre15] Cancel of 'edit global config' still creates config file #347

Closed mmacata closed 9 years ago

mmacata commented 10 years ago

Current Behaviour: When clicking 'Edit global config' in the menu 'webservices' - 'services' and then 'Cancel' the file 'main.xml' is created in the deegree workspace directory in the /services folder.

Expected Behaviour: When clicking 'Cancel' there won't be a config file created.

stephanr commented 10 years ago

Currently the File has been created before the redirect is made to the xmleditor which only loads the file from the workspace. This occours in org.deegree.console.webservices.MainConfig.edit()

We would suggest to add a Notification message, if possible, to infrom the user that the file has been created from template and it wont be deleted if he hit cancel.

segoerke commented 10 years ago

I think, the same behaviour occurs for the proxy.xml file

ghost commented 10 years ago

When a new file is created, we will pass only the reference to the file, and the file will only be saved when user clicks save. In cases the user is only editing, the functionality stays the same.

stephanr commented 10 years ago

see pull request #379