search

deejoe / sugarizer-lite

A lightweight, shallow-clone fork of Sugarizer stripped of the two largest activities
Apache License 2.0
3 stars 5 forks source link

Develop Math-Hurdler for Sugarizer #21

Open zsd7200 opened 4 years ago

zsd7200 commented 4 years ago

Main issue for discussion of math-hurdler development.

I'm beginning work on the start screen, and I have created a branch that I'm currently working in which can be found here.

zsd7200 commented 4 years ago

My branch has pretty much completed the front-end work. The title screen changes from green to pink like in the original, the horse has better animation than the original, and the layout of buttons and whatnot is nearly identical. Now we just need to work on actually porting the game logic over. Shouldn't be too hard, I have a few ideas on how to do this already, and I marked those ideas down in comments in activity.js. One thing I didn't work on at all was re-implementing the sound files from the original, even though they are in the branch.

iggyvolz commented 4 years ago

I can take the main gameplay logic - I'm leaving a global function getProblem() to generate the problems to handle that later (right now it just gives "problem" with "wrong1", "right2", "wrong3", and "wrong4").

iggyvolz commented 4 years ago

Got the game loop working fairly well - https://github.com/ritjoe/sugarizer-lite/tree/iggyvolz/mathhurdler-gamelogic - now just need to generate fractions for use

zsd7200 commented 4 years ago

Awesome! I just addressed some CSS issues in this branch, namely the horizontal scrollbar when the unicorn gets to the edge of the screen and the game over text appearing small and in the top-left corner. I also modified your hardcoded horizontal pixel values based off of window.innerWidth, so it scales better. This also fixed an issue I was having when I first ran your branch where the unicorn would stop after the hurdle instead of before, and the jump would send the unicorn offscreen. The only major issue I can see now is the fraction generation. It works fine as it is now, but a problem can occur where there are two answers that are either identical (I have seen 1/3 come up twice in the same set of answers; even though 1/3 was the incorrect response, I assume that this can happen with the correct response as well, and that could be an issue) or they can be identical when simplified (I had 0/9, 0/3, and 0/3 come up as options on one of them. The correct response was 0/9, but effectively, all three of those answers should have been right). After addressing that, I'm not sure there's much else we need to do. Great work on the game loop, though! Aside from that slight fraction generation bug, everything looks great.

ghost commented 4 years ago

I want to note the corresponding activity description issue

11

as participants in each issue can earn credit working across the lines with their counterparts in the other, corresponding issue (developers seeking or offering feedback from/to describers and vice versa).

iggyvolz commented 4 years ago

@zsd7200 I actually had that fixed last night, but my network cut out just as I went to git push. All the fractions are simplified and it will reject the problem if there are multiple identical answers (https://github.com/ritjoe/sugarizer-lite/commit/49126d4421f7a8e91cd1d3eac309f0ff0857b5f2#diff-57d26d15859284e359f999e30e75dda7R67 certainly isn't the best way to do it but it works)

zsd7200 commented 4 years ago

Oh awesome. So once we merge branches, we should be pretty much done, right?

zsd7200 commented 4 years ago

Just merged branches now and did a couple fixes that were caused by merging. That branch is available here. Great job on the fraction generation, now I'm having a tough time playing, haha.