Extending Four Side Room to (flexible) Eight Side Room

[ThmsKnz]

Project:

• [X] Egoventure
• [ ] Parrot
• [ ] Speedy Gonzales
• [ ] Safehouse
• [ ] sheets to frames addon
• [ ] Godot asset lib Github action

Is your feature request related to a problem? Please describe. Having a four side view sometimes is not sufficient in case there are five to six views that need to be arranged in one scene. Example would be the floor in Carol's Home where there are more than 4 views (e.g. kitchen door, bathroom door, sleeping room, living room, closet, main door).

Describe the solution you'd like I've therefore added a new class EightSideRoom in my game that is similar to the FourSideRoom which allows to define up to 8 textures and which jumps on left/right click to the next available texture clockwise or counter-clockwise. The class can also be used to define a three side room as it skips all views with an empty texture.

Describe alternatives you've considered Another alternative I used was to extend the FourSideRoom class for a dedicated five view scene by overwriting the _left_texture_set and _right_texture_set functions to embed an additional fifth scene into the FourSideRoom navigation. But I would rather see this as workaround and would favor a flexible EightSideRoom solution.

Additional context .

[dploeger]

Very cool. Can you create a pr for this?

[ThmsKnz]

OK, PR is created. Bear with me if it is not perfect. It's my first pull request and took me awhile to get familiar with git and GitHub :-) I first tried it without forking which failed due to missing authorization when pushing the branch. As said, I'm a newbie here...

[MikaelNyqvist]

I like this very much! It takes care of all the chores a +FourSideRoom entails. Would it work for 3-sides too?

[ThmsKnz]

Yes, it works for 2 or 3-sides as well.

[MikaelNyqvist]

Excellent! (I see now that it says so in the description). :)

[dploeger]

Fixed in deep-entertainment/egoventure-example-game#7