FreePhoenix888
commented
11 months ago Commits I have done:
- https://github.com/deep-foundation/deep-memo-app/commit/982b63e25ff83b58027211ada68a2442c369da0f
- https://github.com/deep-foundation/deep-memo-app/commit/52e31e68bceda89f21f29001716a272eefdc87fb
New error: https://github.com/deep-foundation/deep-memo-app/actions/runs/7206827139/job/19632419281
We have electron-unhandled dependency in both package.json and package-lock.json:
https://github.com/deep-foundation/deep-memo-app/blob/52e31e68bceda89f21f29001716a272eefdc87fb/electron/package.json#L33
https://github.com/deep-foundation/deep-memo-app/blob/52e31e68bceda89f21f29001716a272eefdc87fb/electron/package-lock.json#L1834-L1845
But npm ci is executed afteer build-electron. If we move it before build-electron we will get the previous error that tells that package.json and package-lock.json are not syncronized.
Question: What should syncronize package.json and package-lock.json by calling npm install? Developer manually? build-electron script? Should we use npm install instead of npm clean-install in github actions?
ivansglazunov
Description
[OS Builds github workflow falls with error](https://github.com/deep-foundation/deep-memo-app/actions/runs/7206567841/job/19631658968)Questions
Why is `build-electron` script not used before `cd electron` to generate fresh electron folder?
`build-electron` script: https://github.com/deep-foundation/deep-memo-app/blob/4552d5a7a712b260a8329a59f22634d1f281fbd4/package.json#L25 Step with `cd electron`: https://github.com/deep-foundation/deep-memo-app/blob/f4228339fcc1310a8c6957b88c9d23ac92f79ad1/.github/workflows/os-builds.yaml#L55-L56Why `--force` option is used for `npm ci`?
https://github.com/deep-foundation/deep-memo-app/blob/f4228339fcc1310a8c6957b88c9d23ac92f79ad1/.github/workflows/os-builds.yaml#L53-L54