search

deep-foundation / npm-packager

NPM packager package for Deep. It handles installation and publication of deep packages.
https://www.npmjs.com/package/@deep-foundation/npm-packager
The Unlicense
8 stars 1 forks source link

Installed packages are contained by npm-packager package #72

Closed Konard closed 10 months ago

Konard commented 1 year ago

IMG_1517

Do we need to create contain link from npm-packager package to Package and PackageNamespace links of installed packages?

At the moment I don't see any reasons to keep as it is. So I suggest to remove contain links from the logic that generates these.

This gives npm-packager permissions to access other packages. It will be harder to modify and publish npm-packager package itself. containTree paths length is increased because of this.

Konard commented 1 year ago

@ivansglazunov do you have any objections to the suggestion?

Konard commented 10 months ago

Screenshot_20240122_140429

Before fix

There contains to packages and their namespaces. There joins from namespaces of packages

Konard commented 10 months ago

Actual change was here https://github.com/deep-foundation/js-docker-isolation-provider/commit/bd22854bb68ae85861beb8fcb2c08fc382ca5051

Konard commented 10 months ago

And here it should be compiled into docker image (in database snapshot): https://github.com/deep-foundation/deeplinks/commit/8912246d26f9df69776992d3f9f5420a3378b662

Konard commented 10 months ago

Screenshot_20240130_142040