LeoDog896
commented
1 year ago - @willuhmjs you don't have to request confirmation for every one of your PRs - people who are subscribed to the repository get it immideately - if you're going to continue this set this as an option for the pull request in the settings (block merge until code review)
- also note that you should probably set PRs to squash and merge instead of just merge
- further note is that you keep on raising issues without confirmation - if you aren't going to wait for confirmation to work on the issue, there's no need to make the issue in the first place - please choose one or the other and if you're going to continue with issues, wait for confirmation from one other person on the team before continuing it
- references:
-
11
-
12
-
7
-
- though I would like to mention that there are legitimate reasons to track changes with issues without confirmation (e.g. if you use it to track changes on the main branch rather than other branches)
- references:
- @Lstriker1268 did you actually review the PR? Or are you just saying it to say it? It's fine if you are, but I do have an idea to actually make the reviews worthwhile [ref below] (and if it doesn't happen, please make sure you actually review the changes next time, thanks!)
- We need some form of automatic deployment for previewing changes on pull requests - since @Daniel-Tomov and @Lstriker1268 are unfamiliar with web code, having a visual deployment for confirmation would be nice, that way they can easily do legitimate reviews on changed parts of the website -- maybe we can integrate with Vercel? (Github currently does not have support for it, however it is in the works.)
willuhmjs
Addresses issue #11