deep5050 / radio-active

Play any radios around the globe right from the terminal :zap:
https://www.radio-browser.info/#/
MIT License
509 stars 25 forks source link

Refactor code to use the same internal api for cli and interactive interface #79

Open l-wegner opened 1 year ago

l-wegner commented 1 year ago

Is your feature request related to a problem? Please describe. Currently there are function, which are available in cli and some are available in interactive interface. Adding new functionality is quite distributed.

Describe the solution you'd like Having an internal API, which encapsulates the player, the recording, the favs, and the stations db, would allow cleaning up the main.py regarding the parsed arguments and allows for implementing a better interactive interface. Further more extract the ui printing.

In the best case the utilities.py is almost empty afterwards.

Additional context Add any other context or screenshots about the feature request here.

github-actions[bot] commented 1 year ago

Hi, @l-wegner, Thanks for your contribution :blue_heart: . Contributors :people_holding_hands: like you make the open source community :earth_africa: such an amazing place to learn :book: , inspire :angel:, and create :art: . We will investigate :eyes: and get back to you as soon as possible :+1: . Just make sure you have given us sufficient information :information_source:.

By that time enjoy this meme :point_down: , hope you like it :smile:

meme

Use this action on your projects. Use jokes on issues instead.

l-wegner commented 1 year ago

I'll start this tomorrow.

deep5050 commented 1 year ago

yes, I also feel that. need to refactor before I add new features. we can discuss the design

umop3plsdn commented 1 year ago

omg this would be amazing or even the ability to use socat to listen in to the dumped json so we can integrate into other apps like current song or station info

deep5050 commented 1 year ago

omg this would be amazing or even the ability to use socat to listen in to the dumped json so we can integrate into other apps like current song or station info

did not get it!