deep5050 / radio-active

Play any radios around the globe right from the terminal :zap:
https://www.radio-browser.info/#/
MIT License
469 stars 24 forks source link

Station name update for direct url #91

Closed marvoh closed 8 months ago

marvoh commented 8 months ago

When you add your radio station from URL, it is assigned the name "N/A". This becomes problematic when you want to record the from the station because the default naming structure is FILE_PATH/STATION_NAME_FILE_NAME.EXT.

In Linux you will end up getting directory "N/A" does not exist.

This update attempts to get the station name from header 'ICY-Name' from the URL provided

Updated custom URL name from 'N/A' to 'Custom Station'

github-actions[bot] commented 8 months ago

Hi, @marvoh, Thanks for opening this PR :blue_heart: . Contributors :people_holding_hands: like you make the open source community :earth_africa: such an amazing place to learn :book: , inspire :angel:, and create :art: . We will review it :eyes: and get back to you as soon as possible :+1: . Just make sure you have followed the contribution guidelines.

By that time enjoy this meme :point_down: , hope you like it :smile:

meme

Use this action on your projects. Use jokes on issues instead.

deep5050 commented 8 months ago

Thank you so much for the bug and solution. I totally overlooked it! I'm going to test it.

deep5050 commented 8 months ago

please run make before submitting the PR again

deep5050 commented 8 months ago

@all-contributors please add @marvoh for code,bug

allcontributors[bot] commented 8 months ago

@deep5050

I've put up a pull request to add @marvoh! :tada: