search

deepak1556 / gulp-browserify

Bundle modules with BrowserifyJS
MIT License
195 stars 45 forks source link

Include file name and line number in error message for syntax errors #56

Closed shuhei closed 10 years ago

shuhei commented 10 years ago

As @nickdima pointed out at #37, it would be nice to show file name and line number of syntax error.

Browserify and some transforms like coffeeify emits ParseError defined in node-syntax-error. It has file name and line number in annotated property. So let's use it if available.

deepak1556 commented 10 years ago

Nice! but you seem to be passing the original error object in the place of options ??

deepak1556 commented 10 years ago

@shuhei feel free to merge it when the travis build is fixed :) will publish it first thing in the morning, Thanks!

shuhei commented 10 years ago

@deepak1556 Thanks! Fixed the CI error and stopped passing the original error. I'll merge as soon as Travis says OK.

shuhei commented 10 years ago

Merging. By the way, it's weird to get unexpected MATH on my mac and unexpected ** on Travis. Both of them are on Node v0.10.25. The meanings seem to be the same though.

deepak1556 commented 10 years ago

@shuhei published :+1: