search

deepak1556 / gulp-browserify

Bundle modules with BrowserifyJS
MIT License
195 stars 45 forks source link

breaking on errors from some transforms #57

Open nickdima opened 10 years ago

nickdima commented 10 years ago

It seems to be breaking when reporting an error in some cases. In my case it happens with reactify which is strange because as far as I know this transform should report the syntax errors (I know in grunt the errors from reactify were showing up).

Error: Missing error message
  at new PluginError (/project/node_modules/gulp-util/lib/PluginError.js:54:28)
  at wrapWithPluginError (/project/node_modules/gulp-browserify/index.js:37:10)
  at Stream.<anonymous> (/project/node_modules/gulp-browserify/index.js:96:28)
  at Stream.<anonymous> (/project/node_modules/gulp-browserify/node_modules/browserify/index.js:292:22)
  at Stream.<anonymous> (/project/node_modules/gulp-browserify/node_modules/browserify/index.js:292:22)
  at Stream.EventEmitter.emit (events.js:117:20)
  at Stream.EventEmitter.emit (events.js:117:20)
  at Stream.EventEmitter.emit (events.js:117:20)
  at Stream.EventEmitter.emit (events.js:117:20)
  at Stream.compile (/project/node_modules/reactify/index.js:30:14)
  at _end (/project/node_modules/reactify/node_modules/through/index.js:65:9)
  at Stream.%
shuhei commented 10 years ago

Oh, reactify emits a plain string as an error. We should handle that.

On Feb 18, 2014, at 8:52 AM, Nick Dima notifications@github.com wrote:

It seems to be breaking when reporting an error in some cases. In my case it happens with reactify which is strange because as far as I know this transform should report the syntax errors (I know in grunt the errors from reactify were showing up).

Error: Missing error message at new PluginError (/project/node_modules/gulp-util/lib/PluginError.js:54:28) at wrapWithPluginError (/project/node_modules/gulp-browserify/index.js:37:10) at Stream. (/project/node_modules/gulp-browserify/index.js:96:28) at Stream. (/project/node_modules/gulp-browserify/node_modules/browserify/index.js:292:22) at Stream. (/project/node_modules/gulp-browserify/node_modules/browserify/index.js:292:22) at Stream.EventEmitter.emit (events.js:117:20) at Stream.EventEmitter.emit (events.js:117:20) at Stream.EventEmitter.emit (events.js:117:20) at Stream.EventEmitter.emit (events.js:117:20) at Stream.compile (/project/node_modules/reactify/index.js:30:14) at _end (/project/node_modules/reactify/node_modules/through/index.js:65:9) at Stream.% \ Reply to this email directly or view it on GitHub.