deepak1556 / gulp-browserify

Bundle modules with BrowserifyJS
MIT License
195 stars 45 forks source link

please update browserify. You're requiring 3.x, the current version is 6.x #77

Closed Pomax closed 9 years ago

Pomax commented 9 years ago

This is causing all kinds of problems with bugs that got fixed since the 3.x release of browserify (particularly browserify builds breaking because 3.x had files that didn't pass esprima's quality filters).

Could I ask you up browserify and browserify-shim's versions and push up a new release for gulp-browserify to npm?

shuhei commented 9 years ago

@Pomax This plugin is blacklisted by the gulp team as stated in the README and is not going to be maintained any more. You can use browserify directly with gulp. See https://github.com/gulpjs/gulp/blob/master/docs/recipes/browserify-uglify-sourcemap.md for more details.

sogko commented 9 years ago

I second that suggestion with using the browserify library directly. I've shared some notes on why using gulp-browserify is bad (though I think the issue you brought up is the perfect example against it).

Pomax commented 9 years ago

noted, and thanks. Though, if it's blacklisted and discontinued, it might be worth unpublishing from npm so people can't run it anymore.

deepak1556 commented 9 years ago

@sogko @shuhei have added the reference to those articles in the readme, thanks. @Pomax have added deprecation tag , just dont wanna break some1's dependency chain by unpublishing it ;)