search

deepankarsharma / perspective

Apache License 2.0
2 stars 2 forks source link

Computed column api #36

Closed nmichaud closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   52.13%   52.13%           
=======================================
  Files         106      106           
  Lines       10209    10209           
  Branches     1006     1006           
=======================================
  Hits         5322     5322           
  Misses       4555     4555           
  Partials      332      332

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41d3660...6cfe73b. Read the comment docs.

deepankarsharma commented 5 years ago

Merging since this is useful immediately and since you mentioned we might revisit this api in the future. I largely like it, only one comment that we should revisit in the future is the following -

"**

In the future I would like to have dependency objects and use those rather than column names.