v 0.1.2 - Githubissues

deepanprabhu / duckduckgo-images-api

DuckDuckGo Image Search Resuts - Programatically download Image Search Results

The Unlicense

83 stars 24 forks source link

v 0.1.2 #9

Open rachmadaniHaryono opened 4 years ago

rachmadaniHaryono commented 4 years ago

this is continuation from https://github.com/rachmadaniHaryono/we-get/issues/18

parts that must be changed/added

last line of searching 'audi q6'
old print format on printJson function
returning search data instead of printing it
exit with exit(0). use return instead
test suite
use python3. python 2.7 is already discontinued this year
code example how to use the program on readme
handle pr

parts that can be added/changed

remove semicolon ending
sort import
return using yield. this way user can handle how many result are needed.
return None when token parsing failed
type hinting
use urlparser to parse url instead using regex
print_json instead printJson
use 'user-agents' https://pypi.org/project/user-agents/ for user agent
configurable user-agent/sleep time

also maybe contact other recent active fork developer like @mpdev10 and @iainnash

deepanprabhu commented 4 years ago

all the comments look good, let me work on them and send out a PR.

rachmadaniHaryono commented 4 years ago

better contact me at github as i don't check my email as often as github message

deepanprabhu commented 4 years ago

@rachmadaniHaryono - how do we exchange messages ?

rachmadaniHaryono commented 4 years ago

just post on issue page

deepanprabhu commented 4 years ago

Ok, I think we can talk today. Are there any other projects you are working on ? Are you proficient with Java ? I have a project and looking for people to collaborate !

rachmadaniHaryono commented 4 years ago

i'm not proficient with java

Are there any other projects you are working on ?

other than every project on my github page, no.

deepanprabhu commented 4 years ago

@rachmadaniHaryono - I am thinking to build SEO tools, I think python is great for that. Would you be interested in this journey ? I am thinking of huge keyword databases, tools for conducting SEO experiments and eventually a platform for huge crawls, indexing and seo tools.

deepanprabhu commented 4 years ago

I already have a bunch of projects which are hosted with tooling and ready to go. One of them is www.sitemaps.me

rachmadaniHaryono commented 4 years ago

i'm sorry i don't think i want to join that project right now

deepanprabhu commented 4 years ago

Sure, but there are other projects related to gather open data from internet and doing inferences and machine learning on the same. these are related to studying what in a website is causing google positioning and vice versa, to study how traffic flows to a website. @rachmadaniHaryono

rachmadaniHaryono commented 4 years ago

sorry but no

deepanprabhu commented 4 years ago

got it, Thanks !