deepcharles / ruptures

ruptures: change point detection in Python
BSD 2-Clause "Simplified" License
1.59k stars 162 forks source link

[Question] Complex penalties #129

Closed multimeric closed 3 years ago

multimeric commented 3 years ago

I note in the paper you talk about different penalties in section 6.1. However from looking through the library, it seems that ruptures only supports a fixed linear penalty (ie Beta). Am I right to assume that it doesn't work with more complex penalties linear such as AIC?

Further, if I wanted to implement a method were you normally would calculate a p-value of splitting (ie a likelihood ratio test following Chi squared), is the idea that we just have the error() method return the test statistic without testing for significance (ie the raw likelihood ratio), and the penalty constant implies a p-value? I suppose this makes segmentation fast and flexible, but highly dependent on the choice of penalty.

oboulant commented 3 years ago

Hi,

Thanks for your interest in ruptures !

Since this is more of a question/discussion, could you please move this to the discussions section ?

Thanks and see you there,

Olivier

multimeric commented 3 years ago

Done.