deepcharles / ruptures

ruptures: change point detection in Python

BSD 2-Clause "Simplified" License

1.59k stars 162 forks source link

build: add nltk dependency to run docs examples #168

Closed oboulant closed 3 years ago

oboulant commented 3 years ago

Solves https://github.com/deepcharles/ruptures/pull/167/checks?check_run_id=2769725773

codecov[bot] commented 3 years ago

Codecov Report

Merging #168 (38bc02b) into master (dd3dc67) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          40       40           
  Lines         980      980           
=======================================
  Hits          941      941           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd3dc67...38bc02b. Read the comment docs.

oboulant commented 3 years ago

@deepcharles I had to add the dependency to livereload. Not a big fan since according to me it should be mkdocs duty to handle this as a dependency. But not mentionning it as a dependencies fails the > mkdocs build command.

deepcharles commented 3 years ago

This issue is due to a new version of mkdocs where livereload is not listed as a dependency any more although it is used by mkdocstrings (https://github.com/mkdocs/mkdocs/issues/2448). People at mkdocsstrings are currently working on the problem (https://github.com/mkdocstrings/mkdocstrings/issues/295). In the meantime I would rather pin the version of mkdocs to the latest working version (i.e. 1.1.2) instead of adding a dependency to livereload in ruptures.