search

deepcharles / ruptures

ruptures: change point detection in Python
BSD 2-Clause "Simplified" License
1.59k stars 162 forks source link

build: add aarch64 wheel build support #180

Closed odidev closed 3 years ago

odidev commented 3 years ago

Added aarch64 wheel build support. Related to https://github.com/deepcharles/ruptures/issues/179, @julia-shenshina Could you please review this PR?

codecov[bot] commented 3 years ago

Codecov Report

Merging #180 (e4800e8) into master (c76dc78) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          40       40           
  Lines         978      978           
=======================================
  Hits          942      942           
  Misses         36       36

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c76dc78...e4800e8. Read the comment docs.

deepcharles commented 3 years ago

Looks good to me, even though I cannot test it before it is merged. Many thanks!

oboulant commented 3 years ago

Looks good to me, even though I cannot test it before it is merged. Many thanks!

If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ?

deepcharles commented 3 years ago

Looks good to me, even though I cannot test it before it is merged. Many thanks!

If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ?

I can only run the GH Action on a branch from this repo, but not on a branch from a fork.

oboulant commented 3 years ago

Looks good to me, even though I cannot test it before it is merged. Many thanks!

If you manually run the Gh Actions on this specific branch and labelling it as a release candidate, it is not possible to test it ?

I can only run the GH Action on a branch from this repo, but not on a branch from a fork.

In that case, maybe @odidev can modify the PR to be merge on a separate branch on ruptures repo. Then we can test, right ?

odidev commented 3 years ago

Following are the logs for wheel build and test. Please have a look and let me know if any changes are required in the PR:

  1. Wheel build: https://github.com/odidev/ruptures/actions/runs/1036426161

  2. Test logs: https://github.com/odidev/ruptures/actions/runs/1036426160

oboulant commented 3 years ago

Thanks for the links ! Looks good to me, thx !

deepcharles commented 3 years ago

Looks good to me, many thanks.