Closed oboulant closed 3 years ago
Merging #186 (fa42cb0) into master (d211c5c) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 40 40
Lines 978 978
=======================================
Hits 942 942
Misses 36 36
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d211c5c...fa42cb0. Read the comment docs.
As can be seen in the commits, I tested several approaches :
github.event.label.name != 'skip-changelog'
This solution does not work because we do not have the guarantee that the PR is labelled before the jobs are started.... Moreover, the jobs are started regardless of the conditions, it is just that if the condition is met, then we skip the following steps
pre-commit autoupdate
Might work but still, the jobs are started, it is just that the steps after the condition are ignored
If the PR only modifies .pre-commit-config.yaml
, then jobs are ignored.
Does it work now? I am a bit lost
Does it work now? I am a bit lost
Yes it does. I try to explain everything I tried in this comment from the current PR.
Bottom line, yes the PR is ready. And basically what it does is the following : for any newly created PR, if the PR consists only in a modification in .pre-commit-config.yaml
, then we do not run the workflows I mentioned.
By doing so, we can for instance avoid running tests for the automatically created PR from pre-commit-ci
.
Let me know if unclear !
Oh ok cool.
The situation :
As of today, for the PRs automatically generated by
pre-commit-ci
from branchpre-commit-ci-update-config
tomaster
and only affecting.pre-commit-config.yaml
, run all the CI tests like any other PRs.What we do :
When only
.pre-commit-config.yaml
is affected by the PR, then the following Gh Actions are not run :